I like medium tall tanks from 18" to 20" tall because it provides enough depth for most fishes, and also is easy to maintain with my arms, which are longer than normal. I have a 25" deep tank and for maintenance it is too deep.
Plant wise 18 to 20" also seems to be a sweet spot for height, the only issue I have had is with some of my jungle vals getting tangled leaves on the surface of the water.
Fish wise I find for the most part width and length of the tank are more important than the height as long as you maintain 18" of height, with a tank that is deep and narrow the fish just swim back and forth but with some width they swim and interact fore and aft.
Obviously if you are focusing on a particular fish you need to look its requirements first but when the choice is open I would choose wide and long over depth.