The more water you can provide then the better plus lots of filtration and more biological the better.
Depends on if you are talking one tank for the rest of their lives or if you are prepared to upgrade as you go.
For me I would say 50 gallons minimum for those two fish and the minnows for life, but the minnows are in danger of being eaten the bigger the goldies grow.
The comet has a potential to grow to around 18 inches and the shub to around a foot.